feat: introduce convenience Status::verify_is_active method #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
force-pushed
the
a
branch
2 times, most recently
from
0527245
to
a832a83
Compare
Similarly to ChannelEnd::verify_not_closed, introduce a convenience method Status::verify_active which checks whether client’s status is active and returns an error if it isn’t. This simplifies whole bunch of code locations making them more DRY.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
=======================================
Coverage 70.69% 70.69%
=======================================
Files 178 178
Lines 17919 17870 -49
=======================================
- Hits 12667 12634 -33
+ Misses 5252 5236 -16 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Thank you @mina86. This is a straightforward PR.
Just a few comments, then we can wrap it up.
.changelog/unreleased/improvements/1005-status-verify-active.md
Outdated
Show resolved
Hide resolved
Farhad-Shabani
added
the
O: maintainability
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
mina86
changed the title
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: introduce convenience Status::verify_active method Similarly to ChannelEnd::verify_not_closed, introduce a convenience method Status::verify_active which checks whether client’s status is active and returns an error if it isn’t. This simplifies whole bunch of code locations making them more DRY. * Update .changelog/unreleased/improvements/1005-status-verify-active.md Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com> * review --------- Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to ChannelEnd::verify_not_closed, introduce a convenience
method Status::verify_is_active which checks whether client’s status is
active and returns an error if it isn’t. This simplifies whole bunch
of code locations making them more DRY.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.