Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "crossing hellos" logic from channel handshake #157

Closed
Tracked by #143
plafer opened this issue Oct 7, 2022 · 0 comments · Fixed by #181
Closed
Tracked by #143

Remove "crossing hellos" logic from channel handshake #157

plafer opened this issue Oct 7, 2022 · 0 comments · Fixed by #181
Milestone
v0.22.0

Comments

@plafer
Copy link
Contributor

plafer commented Oct 7, 2022 •
edited
Loading

Quote:

  1. Deprecate Version from the ChannelOpenTry message. If the relayer is going to specify a particular version, it should be the INIT relayer choice that determines the ultimate version; not a combination of INIT relayer choice and TRY relayer choice. Note: we will not remove the field as this is a breaking change, we will simply ignore the inputted value.
  2. Change OnChanOpenTry to return version string, err error. Core IBC will then set the channel struct with the version chosen by OnChanOpenTry
@plafer plafer mentioned this issue Oct 7, 2022
Closed
7 tasks
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@DaviRain-Su
Merge pull request cosmos#157 from octopus-network/feature/beefy-cs
ed53aec 
Complete on-chain storage verification
@plafer plafer mentioned this issue Oct 14, 2022
Merged
12 tasks
@plafer plafer added this to the v0.21.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging a pull request may close this issue.

Remove crossing hellos from Channel cosmos/ibc-rs
1 participant
@plafer