Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in modules regarding the type Height #121

Closed
4 tasks
adizere opened this issue Aug 3, 2020 · 0 comments
Closed
4 tasks

Ambiguity in modules regarding the type Height #121

adizere opened this issue Aug 3, 2020 · 0 comments

Comments

@adizere
Copy link
Contributor

adizere commented Aug 3, 2020

Summary of Bug

There are currently two type declarations for Height in the modules:

  1. A general definition at the top-level of modules:

https://github.com/informalsystems/ibc-rs/blob/65487863a68e6307d1b08c02f202a4ba1f2c6340/modules/src/lib.rs#L36

  1. Then the Height being used in each specific module is different, for example:

https://github.com/informalsystems/ibc-rs/blob/c447e63692c663a6af325196e8f92cf9a32bf91d/modules/src/ics03_connection/events.rs#L11-L14

Both types are imported from tendermint (one from the light the other from block) and both boil down to a u64. Unless there is a specific reason to keep both, we should be consistent here. Even better, maybe we can have our own definition of a Height that is (in some sense) even more general than the definitions from tendermint.

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
* Add tags to codecov reports

* Trigger CI when workflows definitions are updated

* Trigger CI

* Fix TS workflow

* Fix codecov tags => flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant