Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grpc-gateway error codes #9015

Merged
merged 8 commits into from
Mar 29, 2021
Merged

fix: grpc-gateway error codes #9015

merged 8 commits into from
Mar 29, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Mar 28, 2021 •
edited
Loading

Description

closes: #8902
closes: #8652

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 29, 2021 •
edited
Loading

Codecov Report

Merging #9015 (1d341a4) into master (04246ef) will decrease coverage by 0.00%.
The diff coverage is 65.51%.

❗ Current head 1d341a4 differs from pull request most recent head 119f6a6. Consider uploading reports for the commit 119f6a6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9015      +/-   ##
==========================================
- Coverage   58.87%   58.87%   -0.01%     
==========================================
  Files         572      573       +1     
  Lines       32073    32091      +18     
==========================================
+ Hits        18884    18893       +9     
- Misses      10978    10987       +9     
  Partials     2211     2211
Impacted Files Coverage Δ
client/query.go 16.98% <0.00%> (-3.48%) ⬇️
x/bank/legacy/v040/migrate.go 100.00% <100.00%> (ø)
x/bank/legacy/v040/types.go 100.00% <100.00%> (ø)
x/bank/legacy/v043/store.go 84.61% <100.00%> (+2.00%) ⬆️
x/bank/module.go 59.09% <100.00%> (+0.95%) ⬆️
x/slashing/module.go 59.09% <100.00%> (ø)

@aleem1314 aleem1314 marked this pull request as ready for review March 29, 2021 09:33
@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

Should we backport this?

@aleem1314
Copy link
Contributor Author

Should we backport this?

Yes

tac0turtle
tac0turtle approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, could you add a changelog?

amaury1093
amaury1093 approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aleem1314

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 29, 2021
@mergify mergify bot merged commit 636e659 into master Mar 29, 2021
@mergify mergify bot deleted the aleem/8902-grpc-error-codes branch March 29, 2021 13:42
@amaury1093
Copy link
Contributor

hmm, it seems like mergify doesn't backport automatically anymore.

@Mergifyio backport release/v0.42.x ?

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x ?: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active
  • Backport to branch ? failed: Branch not found

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

@Mergifyio backport release/v0.42.x

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

@Mergifyio backport release/v0.42.x

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

@Mergifyio backport release/v0.42.x

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

@Mergifyio backport release/v0.42.x

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

(nevermind my repeated message, I'm trying to fix the issue w/ the @okwme and @hxrts assistance)

@alessio
Copy link
Contributor

alessio commented Mar 29, 2021

@Mergifyio backport release/v0.42.x

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2021

Command backport release/v0.42.x: failure

No backport have been created

  • Backport to branch release/v0.42.x failed
    backport fail: repository is too big and no subscription is active

@orijbot
Copy link

orijbot commented Mar 29, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=f1e194cdbb6b4a158139d5285533172c

@orijbot
Copy link

orijbot commented Mar 29, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=1641198dae3248379927641d7c61f1c3

@orijbot
Copy link

orijbot commented Mar 29, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=636e6598b96c019647e9ef69f69a9f8fee435e79

@orijbot
Copy link

orijbot commented Mar 29, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=1d341a4a34bea11e55a28eeed6ba4f833bc514ee

@orijbot
Copy link

orijbot commented Mar 29, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=d3b90bac2b64e5f21cf80004a244c4d0dbbe16c5

aleem1314 added a commit that referenced this pull request Apr 8, 2021
@aleem1314 @amaury1093
backport (#9015)
0ccf3b2 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@aleem1314 aleem1314 mentioned this pull request Apr 8, 2021
Merged
9 tasks
alessio pushed a commit that referenced this pull request Apr 8, 2021
@aleem1314 @amaury1093
[Backport] fix: grpc-gateway error codes (#9015) (#9078)
c029a93 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

@anilcse anilcse Awaiting requested review from anilcse

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
5 participants
@aleem1314 @alessio @amaury1093 @orijbot @tac0turtle