Patch Release v0.34.2 (develop) #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: gamarin2 <gautier@tendermint.com>
* Support pagination and status query params for /staking/validators * Rename BondStatusToString to String * Cherry pick 4181 * Remove pending log
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #4185 +/- ##
==========================================
+ Coverage 60.16% 60.2% +0.03%
==========================================
Files 212 212
Lines 15187 15187
==========================================
+ Hits 9137 9143 +6
+ Misses 5421 5415 -6
Partials 629 629 |
fedekunze
reviewed
Apr 25, 2019
rigelrozanski
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Things look good - left a few comments on #4176 (review) which may be worth double checking but the only important one is this typo
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release patch release v0.34.2 to
develop. Conflicts will be addressed after the release is merged to master (#4184).ref: #4178
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: