Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Release v0.34.2 (master) #4184

Merged
merged 8 commits into from
Apr 25, 2019
Merged

Patch Release v0.34.2 (master) #4184

merged 8 commits into from
Apr 25, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 24, 2019

Release patch release v0.34.2 to master.

ref: #4178


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4184 into master will decrease coverage by <.01%.
The diff coverage is 48.78%.

@@            Coverage Diff            @@
##           master   #4184      +/-   ##
=========================================
- Coverage      60%     60%   -0.01%     
=========================================
  Files         212     212              
  Lines       15127   15153      +26     
=========================================
+ Hits         9077    9092      +15     
- Misses       5427    5434       +7     
- Partials      623     627       +4

@alexanderbez
Copy link
Contributor Author

Let's run a multi-seed simulation on this first.

@jackzampolin jackzampolin merged commit 13bd5b6 into master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants