chore: regenerate addrbook.json for in-place-testnet

[czarcas7ic]

Description

Closes: #XXXX

Since moving to sdk v0.50, we noticed lots of error logs when running in-place-testnet:

After some experimentation, I realized this is coming from peers from the old network sending us votes that do not correlate to our network. It's important to note that the network was still running, just every block we would get 150 lines of vote errors.

The simple solution here is to just regenerate our addrbook.json when running in-place-testnet. After this fix, we get nice normal logs:

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Chores
  • Updated the CHANGELOG.md to document the regeneration of the addrbook.json file for the in-place testnet.
  • Implemented functionality to reset the addrbook.json file, ensuring a clean state for the testnet environment.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve updating the CHANGELOG.md to document the regeneration of the addrbook.json file for the in-place testnet. Additionally, the server/start.go file has been modified to implement functionality that regenerates the addrbook.json file, ensuring it is reset to a clean state by removing any existing file and writing an empty JSON object.

Changes

File(s)	Change Summary
CHANGELOG.md	Added an entry under the testnet section documenting the regeneration of addrbook.json.
server/start.go	Implemented functionality to regenerate addrbook.json, including file removal and writing an empty JSON object.

Possibly related PRs

• chore: sync changelog with latest releases #21658: This PR also involves changes to the CHANGELOG.md file, focusing on updates and organization, which is directly related to the main PR's addition of a new entry in the same file.

Suggested reviewers

• sontrinh16

Warning

Review ran into problems

🔥 Problems

Error running LanguageTool: LanguageTool error: Unknown error

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (4)

server/start.go (1)

784-793: LGTM! Consider adding error logging.

The changes to regenerate the addrbook.json file look good and should address the issue with old peers causing error logs. This ensures a clean start for the in-place testnet.

Consider adding error logging for the file removal operation. While the code correctly ignores the case where the file doesn't exist, it might be helpful to log other types of errors that could occur during removal. Here's a suggested modification:

 if err := os.Remove(addrBookPath); err != nil && !os.IsNotExist(err) {
-    return nil, fmt.Errorf("failed to remove existing addrbook.json: %w", err)
+    ctx.Logger.Error("failed to remove existing addrbook.json", "error", err)
+    // Decide if you want to return the error or continue with the operation
 }

This change would provide more visibility into any issues that might occur during the file removal process without necessarily halting the entire operation.

CHANGELOG.md (3)

Line range hint 29-38: Critical state machine breaking changes

Several state machine breaking changes have been introduced:

1. Changes to x/gov, x/group, and x/staking modules.
2. Modifications to store keys and balance tracking.

These changes will require careful migration of existing state. Developers must ensure they follow the upgrade instructions precisely to avoid data inconsistencies.

---

Line range hint 40-54: Extensive API breaking changes

Numerous API breaking changes have been made across various modules and components:

1. Renaming of functions and methods.
2. Changes to parameter types and return values.
3. Removal of deprecated functionality.

Developers will need to update their code to accommodate these changes. It's recommended to thoroughly review the API changes and test the application thoroughly after upgrading.

---

Line range hint 56-62: Client breaking changes affecting CLI and queries

Several changes affect client interactions:

1. Removal of legacy REST API.
2. Changes to CLI commands and flags.
3. Modifications to query responses.

Users and developers relying on these interfaces will need to update their scripts and applications accordingly.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 648ef5f and 4e4e69c.

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• server/start.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

server/start.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

🔇 Additional comments (5)

CHANGELOG.md (5)

Line range hint 1-3: New major version release with significant changes

This CHANGELOG entry represents a major version release (v0.47.0) of the Cosmos SDK. Developers should pay close attention to the breaking changes and new features when upgrading from previous versions.

---

Line range hint 5-16: Notable new features added

Several important features have been added in this release:

1. Support for Core API in the runtime.
2. New prune CLI command for manual pruning of app store history.
3. Implementation of ADR-038 for state streaming service.
4. Support for custom read and write gRPC options in app.toml.

These features enhance the flexibility and functionality of the SDK. Developers should review these additions to see if they can benefit their applications.

---

Line range hint 18-27: Significant improvements to existing functionality

Key improvements include:

1. Optimization of iteration on nested cached KV stores.
2. Support for state streaming configuration in app.toml.
3. Removal of the params module and migration to self-managed parameters for various modules.

These improvements can lead to better performance and easier configuration. Developers should consider updating their applications to take advantage of these enhancements.

---

Line range hint 64-73: Important bug fixes

Multiple bug fixes have been implemented, addressing issues in various modules and components. Notable fixes include:

1. Corrections to x/auth, x/bank, and x/gov modules.
2. Improvements to error handling and panic recovery.
3. Fixes for race conditions and performance issues.

These bug fixes enhance the stability and reliability of the SDK. Developers should review these fixes to understand if they resolve any issues they've encountered in previous versions.

---

Line range hint 1-142: Summary: Major release with extensive changes requiring careful migration

This v0.47.0 release of the Cosmos SDK introduces significant changes across the board, including new features, improvements, and numerous breaking changes. Key points for developers:

1. New features like Core API support and state streaming enhance the SDK's capabilities.
2. Performance improvements and optimizations have been implemented in various areas.
3. Extensive breaking changes affect the state machine, APIs, and client interfaces.
4. Multiple bug fixes address various issues from previous versions.

Given the scope of changes, developers should:

• Plan for a careful and thorough migration process.
• Extensively test their applications after upgrading.
• Review all breaking changes and update their code accordingly.
• Consider the potential benefits of new features and improvements for their applications.

It's highly recommended to read the full CHANGELOG and any additional upgrade guides provided by the Cosmos SDK team before attempting to upgrade to this version.

[julienrbrt]

utACK