Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): sync changelog #21025

Merged
merged 2 commits into from
Jul 23, 2024
Merged

chore(core): sync changelog #21025

merged 2 commits into from
Jul 23, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 22, 2024 •
edited by coderabbitai bot
Loading

Description

Follow-up of #21022
Preventively retracts v0.12 as well (although that will effectively happen when we tag core v1)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced appmodule.HasPreBlocker interface for enhanced pre-block processing capabilities.

  • Improvements

    • Consolidated dependency injection management under a single namespace for better organization.
    • Comet service now returns structured data, improving clarity in interactions with the service.

  • Bug Fixes

    • Retraction of a problematic dependency version to prevent compatibility issues.

  • Documentation

    • Updated changelog versioning to reflect new changes and structural improvements.

@julienrbrt julienrbrt requested a review from a team as a code owner July 22, 2024 15:43
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates to the Cosmos SDK emphasize restructuring and enhancing code clarity, particularly in dependency management and component interfaces. Key changes include the relocation of the coin.ParseCoin function, consolidation of depinject dependencies, and the removal of unused code. Additionally, the Comet service has been streamlined to return structs instead of interfaces, improving data handling. These modifications, along with versioning updates, enhance maintainability and the developer experience.

Changes

Files Change Summary
core/CHANGELOG.md - coin.ParseCoin relocated to client/v2/internal.
- Consolidated depinject dependencies under cosmossdk.io/depinject.
- Removed HasEventListeners from appmodule.
- Comet service now returns structs, renaming BlockInfo to Info and BlockInfoService to CometInfoService.
- Added appmodule.HasPreBlocker interface.
- Version updated to v0.11.1, with depinject upgraded to 1.0.0.
core/go.mod - Introduced a retract directive for version v0.12.0, marking it as incompatible with v0.50.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba7e6be and 0116d3b.

Files selected for processing (2)
  • core/CHANGELOG.md (1 hunks)
  • core/go.mod (1 hunks)
Additional context used
Path-based instructions (1)
core/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (6)
core/go.mod (1)

19-23: LGTM! The retract directive is correctly added.

The retract directive for version v0.12.0 is correctly added to prevent potential compatibility issues.

core/CHANGELOG.md (5)

69-71: LGTM! The changelog entry is clear and correctly formatted.

The entry for upgrading depinject to v1.0.0 is clear and correctly formatted.

73-75: LGTM! The changelog entry is clear and correctly formatted.

The entry for adding the appmodule.HasPreBlocker interface is clear and correctly formatted.

Line range hint 77-79:
LGTM! The changelog entry is clear and correctly formatted.

The entry for adding the appmodule.UpgradeModule interface is clear and correctly formatted.

Tools
LanguageTool

[style] ~64-~64: ‘due to the fact that’ might be wordy. Consider a shorter alternative.
Context: ...ntListeners` was removed from appmodule due to the fact that it was not used anywhere in the SDK nor...

(EN_WORDINESS_PREMIUM_DUE_TO_THE_FACT_THAT)

Line range hint 81-83:
LGTM! The changelog entry is clear and correctly formatted.

The entry for adding AppHash to header.Info is clear and correctly formatted.

Tools
LanguageTool

[style] ~64-~64: ‘due to the fact that’ might be wordy. Consider a shorter alternative.
Context: ...ntListeners` was removed from appmodule due to the fact that it was not used anywhere in the SDK nor...

(EN_WORDINESS_PREMIUM_DUE_TO_THE_FACT_THAT)

Line range hint 85-87:
LGTM! The changelog entry is clear and correctly formatted.

The entry for updating comet.VoteInfo and adding gas.Service and gas.GasMeter interfaces is clear and correctly formatted.

Tools
LanguageTool

[style] ~64-~64: ‘due to the fact that’ might be wordy. Consider a shorter alternative.
Context: ...ntListeners` was removed from appmodule due to the fact that it was not used anywhere in the SDK nor...

(EN_WORDINESS_PREMIUM_DUE_TO_THE_FACT_THAT)

coderabbitai[bot]
coderabbitai bot reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0116d3b and da8f857.

Files selected for processing (1)
  • core/go.mod (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • core/go.mod

@julienrbrt julienrbrt added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit d80eba9 Jul 23, 2024
70 checks passed
@julienrbrt julienrbrt deleted the julien/core branch July 23, 2024 14:04
alpe added a commit that referenced this pull request Jul 23, 2024
@alpe
Merge branch 'main' into alex/sims2_s0
8018c01 
* main:
  refactor(schema)!: move bech32 address prefixes to a higher level (#21026)
  chore(core): sync changelog (#21025)
tac0turtle pushed a commit that referenced this pull request Jul 27, 2024
@julienrbrt @tac0turtle
chore(core): sync changelog (#21025)
dd909c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@hieuvubk hieuvubk hieuvubk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @tac0turtle @hieuvubk