Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #20662

Merged
merged 2 commits into from
Jun 13, 2024
Merged

chore: fix typos #20662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d1aa3
fix typos
TiesD Jun 13, 2024
e7430c5
fix more typos
TiesD Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/v2/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
func Commands(logger log.Logger, homePath string, modules ...ServerModule) (CLIConfig, error) {
if len(modules) == 0 {
// TODO figure if we should define default modules
// and if so it should be done here to avoid uncessary dependencies
// and if so it should be done here to avoid unnecessary dependencies
return CLIConfig{}, errors.New("no modules provided")
}

Expand Down
12 changes: 6 additions & 6 deletions store/cachekv/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func TestCacheKVStoreNested(t *testing.T) {
require.Equal(t, valFmt(1), st.Get(keyFmt(1)))
require.Equal(t, valFmt(3), st2.Get(keyFmt(1)))

// st2 writes to its parent, st. doesnt effect mem
// st2 writes to its parent, st. doesn't effect mem
st2.Write()
require.Equal(t, []byte(nil), mem.Get(keyFmt(1)))
require.Equal(t, valFmt(3), st.Get(keyFmt(1)))
Expand Down Expand Up @@ -238,25 +238,25 @@ func TestCacheKVMergeIteratorBasics(t *testing.T) {
st.Write()
assertIterateDomain(t, st, 0)

// add two keys and assert theyre there
// add two keys and assert they're there
k1, v1 := keyFmt(1), valFmt(1)
st.Set(k, v)
st.Set(k1, v1)
assertIterateDomain(t, st, 2)

// write it and assert theyre there
// write it and assert they're there
st.Write()
assertIterateDomain(t, st, 2)

// remove one in cache and assert its not
// remove one in cache and assert it's not
st.Delete(k1)
assertIterateDomain(t, st, 1)

// write the delete and assert its not there
// write the delete and assert it's not there
st.Write()
assertIterateDomain(t, st, 1)

// delete the other key in cache and asserts its empty
// delete the other key in cache and asserts it's empty
st.Delete(k)
assertIterateDomain(t, st, 0)
}
Expand Down
2 changes: 1 addition & 1 deletion store/pruning/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type Manager struct {
opts types.PruningOptions
snapshotInterval uint64
// Snapshots are taken in a separate goroutine from the regular execution
// and can be delivered asynchrounously via HandleSnapshotHeight.
// and can be delivered asynchronously via HandleSnapshotHeight.
// Therefore, we sync access to pruneSnapshotHeights with this mutex.
pruneSnapshotHeightsMx sync.RWMutex
// These are the heights that are multiples of snapshotInterval and kept for state sync snapshots.
Expand Down
Loading