R4R: ParamStore SubModules #1772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
1cbe025
to
ee55487
Compare
mossid
changed the title
|
Slashing is mostly ready, is it safe to work on Stake? @rigelrozanski |
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
ee55487
to
3c25b2d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1772 +/- ##
==========================================
Coverage ? 63.82%
==========================================
Files ? 140
Lines ? 8235
Branches ? 0
==========================================
Hits ? 5256
Misses ? 2633
Partials ? 346 |
8 tasks
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
3c25b2d
to
fe288d7
Compare
mossid
added a commit
that referenced
this pull request
Jul 23, 2018
add InitGenesis fix lint add immutablestore Merge pull request #1775: ConsensusParams in BaseApp add endblocker in params in progress fix errors fix gaiadebug/hack.go finalize rebase to transientstore branch fix error fix lint finalize merging
mossid
changed the title
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
fe288d7
to
e8207ef
Compare
mossid
added a commit
that referenced
this pull request
Jul 25, 2018
add InitGenesis fix lint add immutablestore Merge pull request #1775: ConsensusParams in BaseApp add endblocker in params in progress fix errors fix gaiadebug/hack.go finalize rebase to transientstore branch fix error fix lint finalize merging fix synerror in progress in progress add gasconfig in params, restructure
mossid
changed the title
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
e8207ef
to
3cb2af5
Compare
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
3cb2af5
to
16a3833
Compare
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
b165b0e
to
47e4853
Compare
mossid
added a commit
that referenced
this pull request
Jul 27, 2018
add InitGenesis fix lint add immutablestore Merge pull request #1775: ConsensusParams in BaseApp add endblocker in params in progress fix errors fix gaiadebug/hack.go finalize rebase to transientstore branch fix error fix lint finalize merging fix synerror in progress in progress add gasconfig in params, restructure fix errors add tests
|
@mossid sorry for the delay in response - yes, I think it's safe to work on stake |
mossid
force-pushed
the
joon/1704-genesis-params
branch
from
c7f027a
to
3782f8d
Compare
fedekunze
reviewed
Aug 26, 2018
| app.checkParams = sdkparams | ||
| } | ||
|
|
||
| func (app *BaseApp) getCheckContext() sdk.Context { |
fedekunze
reviewed
Aug 26, 2018
| @@ -0,0 +1,25 @@ | |||
| package msgstat | |||
There was a problem hiding this comment.
msg state, status or stats (stadistics) ?
|
This PR is quite large. Can we split it up into multiple smaller PR's. The diff is quite hard to review on this. It also appears that the intended review mechanism is not commit by commit, so I don't really have a good way of approaching this in the current state. e.g. |
This was referenced Sep 4, 2018
4 tasks
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add InitGenesis
docs/)CHANGELOG.mdcmd/gaiaandexamples/For Admin Use:
Closes: #1704
Closes: #1007
Closes: #1771
Addresses some points in: #1008