Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ConsensusParams" to baseapp #1007

Closed
cwgoes opened this issue May 16, 2018 · 4 comments
Closed

Add "ConsensusParams" to baseapp #1007

cwgoes opened this issue May 16, 2018 · 4 comments
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented May 16, 2018

Ref #963 (comment)

Also ensure MaxGasPerTx is enforced by baseapp.

@mossid
Copy link
Contributor

mossid commented Jul 19, 2018

Does ConsensusParamUpdates in abci.ResponseEndBlock overrides the existing ConsensusParams only for the non-nil values of the ConsensusParamsUpdates or overrides all? @ebuchman

@ebuchman
Copy link
Member

It only over-rides the non-nil fields in ConsensusParamUpdates. See https://github.com/tendermint/tendermint/blob/v0.25.0/types/params.go#L104.

This means if it wants to eg update the BlockSize.MaxGas, it has to fill out the full BlockSize, so the MaxBytes and the MaxGas. Should we consider changing this behaviour? In any case I don't think this is properly documented Tendermint side!

@jackzampolin
Copy link
Member

Should this be in the paramStore instead? Or is baseApp the right way to go here?

@alexanderbez
Copy link
Contributor

We have params both in the base app and the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants