Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove indentation in REST respones #16142

Merged
merged 2 commits into from
May 13, 2023
Merged

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented May 13, 2023

Description

The GRPC-to-REST gateway converts protobuf responses to JSON. However the marshalling we use for this adds indentation, consuming unnecessary bandwidth for all FE users. I believe I was told that indentation was getting to 20% of bandwidth on queries to full nodes from app.osmosis.zone.

This PR just stops sending the whitespace here.

I believe this is non-breaking, because I'm unaware of any consumer of JSON content, that would break from removal of whitespace.

This shouldn't add debugging overhead, as every browser comes with great JSON viewers, that work independent of the whitespacing.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ValarDragon ValarDragon changed the title Remove indentation in REST respones perf: Remove indentation in REST respones May 13, 2023
@ValarDragon ValarDragon added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label May 13, 2023
@ValarDragon ValarDragon marked this pull request as ready for review May 13, 2023 10:01
@ValarDragon ValarDragon requested a review from a team as a code owner May 13, 2023 10:01
@github-actions

This comment has been minimized.

@julienrbrt julienrbrt added this pull request to the merge queue May 13, 2023
Merged via the queue into main with commit 94dec7a May 13, 2023
@julienrbrt julienrbrt deleted the dev/remove_indent_in_grpc branch May 13, 2023 15:12
mergify bot pushed a commit that referenced this pull request May 13, 2023
(cherry picked from commit 94dec7a)

# Conflicts:
#	CHANGELOG.md
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants