Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move pruning to store #13609

Merged
merged 3 commits into from
Oct 24, 2022
Merged

chore: move pruning to store #13609

merged 3 commits into from
Oct 24, 2022

Conversation

tac0turtle
Copy link
Member

Description

move pruning logic to store.

store is meant to represent all things storage related, I think pruning should live there too.

if not feel free to close


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #13609 (908c11c) into main (3b62a95) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13609      +/-   ##
==========================================
- Coverage   54.70%   54.68%   -0.02%     
==========================================
  Files         645      662      +17     
  Lines       55737    57376    +1639     
==========================================
+ Hits        30489    31377     +888     
- Misses      22760    23451     +691     
- Partials     2488     2548      +60     
Impacted Files Coverage Δ
baseapp/options.go 66.66% <ø> (ø)
server/config/config.go 38.15% <ø> (ø)
server/mock/store.go 18.26% <ø> (ø)
server/pruning.go 72.22% <ø> (ø)
simapp/test_helpers.go 30.25% <ø> (ø)
store/iavl/store.go 56.95% <ø> (ø)
store/mem/store.go 82.35% <ø> (ø)
store/pruning/manager.go 95.18% <ø> (ø)
store/pruning/types/options.go 100.00% <ø> (ø)
store/rootmulti/dbadapter.go 0.00% <ø> (ø)
... and 20 more

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog?

@tac0turtle tac0turtle merged commit 04db139 into main Oct 24, 2022
@tac0turtle tac0turtle deleted the marko/move-pruning branch October 24, 2022 12:02
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* move pruning to store

* add changelog entry

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants