Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(group): CLI tests using Tendermint Mock #13067

Merged
merged 12 commits into from
Sep 5, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #13035


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #13067 (0c704e5) into main (4fe7797) will decrease coverage by 2.01%.
The diff coverage is 47.01%.

❗ Current head 0c704e5 differs from pull request most recent head 9e441e7. Consider uploading reports for the commit 9e441e7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13067      +/-   ##
==========================================
- Coverage   55.87%   53.86%   -2.02%     
==========================================
  Files         646      650       +4     
  Lines       54895    55343     +448     
==========================================
- Hits        30675    29811     -864     
- Misses      21762    23149    +1387     
+ Partials     2458     2383      -75     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/context.go 55.37% <0.00%> (-0.91%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
server/config/config.go 38.00% <0.00%> (-1.59%) ⬇️
server/mock/store.go 19.00% <0.00%> (-0.39%) ⬇️
... and 140 more

Copy link
Contributor

@JeancarloBarrios JeancarloBarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit :)

x/group/client/cli/tx_test.go Show resolved Hide resolved
@alexanderbez alexanderbez enabled auto-merge (squash) September 5, 2022 14:01
@alexanderbez alexanderbez merged commit 2efee04 into main Sep 5, 2022
@alexanderbez alexanderbez deleted the likhita/group-cli-mock branch September 5, 2022 14:31
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor x/group CLI tests to use Tendermint mock
5 participants