Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix/14981 Blocked Vaccination and Recovery Certificates stay in Status BLOCKED after RampDown #5131

Conversation

flxschmidt
Copy link
Contributor

@flxschmidt flxschmidt commented Mar 30, 2023

Description

In hibernation we set the validity state of blocked health certificate to valid.

Link to Jira

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14981

Screenshots

Screenshot 2023-03-30 at 16 16 27

@flxschmidt flxschmidt added the bug Something isn't working label Mar 30, 2023
@flxschmidt flxschmidt added this to the v3.2.0 milestone Mar 30, 2023
@flxschmidt flxschmidt requested a review from a team March 30, 2023 14:13
@flxschmidt flxschmidt changed the title Fix/14981 Blocked Vaccination and Recovery Certificates stay in Stautus BLOCKED after RampDown Fix/14981 Blocked Vaccination and Recovery Certificates stay in Status BLOCKED after RampDown Mar 30, 2023
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Mar 30, 2023

I don't fully understand, the PR title says: "Blocked Vaccination and Recovery Certificates stay in Status BLOCKED after RampDown" and the PR description says: "In hibernation we set the validity state of blocked health certificate to valid.". This is contradictory, what's actually the intended behavior?

@flxschmidt
Copy link
Contributor Author

I don't fully understand, the PR title says: "Blocked Vaccination and Recovery Certificates stay in Status BLOCKED after RampDown" and the PR description says: "In hibernation we set the validity state of blocked health certificate to valid.". This is contradictory, what's actually the intended behavior?

You're right, that's a bit historical grown. That's the title of the bug ticket, but the latest decision is as follows:

  • Certificates REVOKED before EOL should stay REVOKED as the info comes from the revocation list, and the last list known to the mobile is used to evaluate the status (in the best case the information is still available in the app).

  • Certificates INVALID before EOL should stay INVALID as the info comes from the DSC list, and the last list known to the mobile is used to evaluate the status (in the best case the information is still available in the app, otherwise the fallback list should be used).

  • Certificates BLOCKED before EOL are unblocked again after EOL, as this should be part of the Wallet Info, and the Wallet is reset after EOL.

…ecovery-Certificates-stay-in-Stautus-BLOCKED-after-EOL
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Mar 30, 2023

Thanks for the explanation, Felix!

@30mar 30mar merged commit 2ae817a into release/3.2.x Mar 31, 2023
@30mar 30mar deleted the fix/14981-Blocked-Vaccination-and-Recovery-Certificates-stay-in-Stautus-BLOCKED-after-EOL branch March 31, 2023 06:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants