altered runElevated to accept command and args fixing the elevation bug #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
|
Thank you for this. I ended up using it, but I had to add it manually due to several other changes that moved code around. I added a mention/thank you in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current runElevated seems to have issues elevating from non-admin terminal. This change should resolve the elevation issue and return the nicer usage, mirroring the interface for
exec.Command.This change currently does not soft escalate if command run fails in a non elevated state first, can be added if requested.
NB:
I recognise that there are a couple PR's attempting to resolve this issue already pending, they seem to have gone stale, I had tried their impl's but they did not appear to work for me during testing
feel free to reject this PR if you take one of the other in its stead