-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dracut/15coreos-network: enable initramfs networking on Azure #761
Conversation
This enables networking in initramfs on Azure, via a platform condition. While the Ignition configuration may be self-contained locally on the config-drive, other bits referenced by the provisioning flow (e.g. Afterburn hostname and boot check-in) always require reaching remote endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but will defer to jlebon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the added detailed comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll reiterate here I still think at some point we should take advantage of the fact that the metadata endpoint is "link local" and make it so that NM has first-class support for something like networkmanager-primary-link-local-up.target
.
(But bigger picture, maybe there isn't a huge amount of value in avoiding DHCP on clouds because we generally expect most people to use Ignition includes)
@cgwalters That used to be somewhat tracked in coreos/fedora-coreos-tracker#460 though I've closed it now. Can you file a separate tracker issue specifically for this? |
For Azure specifically and thus the scope of this PR, the wireserver is not link-local (in the traditional sense of IPv4LL / RFC3927) but it's a global public IPv4 ( |
Added marmijo to owners file
This enables networking in initramfs on Azure, via a platform
condition.
While the Ignition configuration may be self-contained locally
on the config-drive, other bits referenced by the provisioning
flow (e.g. Afterburn hostname and boot check-in) always require
reaching remote endpoints.
Closes: coreos/fedora-coreos-tracker#689