Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut/15coreos-network: enable initramfs networking on Azure #761

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Dec 3, 2020

This enables networking in initramfs on Azure, via a platform
condition.
While the Ignition configuration may be self-contained locally
on the config-drive, other bits referenced by the provisioning
flow (e.g. Afterburn hostname and boot check-in) always require
reaching remote endpoints.

Closes: coreos/fedora-coreos-tracker#689

This enables networking in initramfs on Azure, via a platform
condition.
While the Ignition configuration may be self-contained locally
on the config-drive, other bits referenced by the provisioning
flow (e.g. Afterburn hostname and boot check-in) always require
reaching remote endpoints.
@lucab lucab requested a review from jlebon December 3, 2020 12:39
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but will defer to jlebon

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the added detailed comment!

@jlebon jlebon merged commit c1cf903 into coreos:testing-devel Dec 3, 2020
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reiterate here I still think at some point we should take advantage of the fact that the metadata endpoint is "link local" and make it so that NM has first-class support for something like networkmanager-primary-link-local-up.target.

(But bigger picture, maybe there isn't a huge amount of value in avoiding DHCP on clouds because we generally expect most people to use Ignition includes)

@jlebon
Copy link
Member

jlebon commented Dec 3, 2020

@cgwalters That used to be somewhat tracked in coreos/fedora-coreos-tracker#460 though I've closed it now. Can you file a separate tracker issue specifically for this?

@lucab
Copy link
Contributor Author

lucab commented Dec 3, 2020

For Azure specifically and thus the scope of this PR, the wireserver is not link-local (in the traditional sense of IPv4LL / RFC3927) but it's a global public IPv4 (168.63.129.16) part of a larger BGP-announced /15 subnet, owned by MS.

@lucab lucab deleted the ups/initrd-azure-neednet branch December 3, 2020 14:39
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure: boot issues due to missing networking in initramfs
4 participants