image: drop hardcoded firstboot network kargs #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the hardcoded `ip=dhcp,dhcp6` from bootloader configuration. The default value has been moved to Afterburn (>= 4.4.0), making this dynamically injected at runtime. On some platforms (e.g. VMware), this also allows user-controlled overriding.
|
are we not dropping the |
|
@dustymabe soon! We'll need (at least) coreos/ignition#956 merged and packaged. The two concerns are decoupled though, so we can land the pieces at different times. |
|
/cc @jlebon |
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
oscontainer.yaml: Actually add this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hardcoded
ip=dhcp,dhcp6from bootloader configuration.The default value has been moved to Afterburn (>= 4.4.0), making
this dynamically injected at runtime. On some platforms (e.g. VMware),
this also allows user-controlled overriding.
Ref: coreos/fedora-coreos-tracker#460