testiso: add unit to verify no failed service #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
changed the title
HuijingHei
commented
Aug 27, 2024
HuijingHei
force-pushed
the
check-service-iso
branch
from
930d5dd
to
c262fb5
Compare
jbtrystram
reviewed
Aug 27, 2024
| Description=TestISO Verify No Failed Service | ||
| OnFailure=emergency.target | ||
| OnFailureJobMode=isolate | ||
| After=rpm-ostree-fix-shadow-mode.service |
There was a problem hiding this comment.
Ordering after this specific one feel too specific. If we add another unit in the future it won't be covered.
Maybe we should add a systemd target, order after it and order all our unit before it.
e.g. coreos-sauce.target :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify coreos/rpm-ostree#4944