disk/s390x: inject firstboot kargs (ignition-network-kcmdline) #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is neither manually tested (lack of HW access) nor automatically tested (lack of CI setup). |
|
/approve Though would be good to get a sanity-check from someone in multi-arch. @Prashanth684 maybe? |
sure. let me give it a go. |
This somehow tries to forward firstboot kargs from a GRUB script to a zipl configuration.
lucab
force-pushed
the
ups/s390-ignition-network-kcmdline
branch
from
df1ae06
to
d43401c
Compare
|
@Prashanth684 thanks for the feedback. Rebased, how does it sound now? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, lucab, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somehow tries to forward firstboot kargs from a GRUB script
to a zipl configuration.
Ref: #1373 (comment)
/cc @jlebon