grub: drop default rd.neednet=1 ip=dhcp,dhcp6 kargs
#1298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to move to a model where networking isn't unconditionally brought up, but instead only if Ignition requires it. But I think we'll still have to keep supporting `ignition_network_kcmdline` since it's kind of part of our API now that it can be overridden via `ignition.firstboot`. Works with: coreos/fedora-coreos-config#321 coreos/ignition-dracut#164 coreos/ignition#956
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 30, 2020
lucab
reviewed
Apr 1, 2020
| @@ -44,8 +44,7 @@ fi | |||
| # which is used in the kernel command line. | |||
| set ignition_firstboot="" | |||
| if [ -f "/ignition.firstboot" ]; then | |||
| # default to dhcp networking parameters to be used with ignition | |||
| set ignition_network_kcmdline='rd.neednet=1 ip=dhcp,dhcp6' | |||
There was a problem hiding this comment.
Who will inject this default later on, and how will overriding work?
There was a problem hiding this comment.
Answering to myself: the whole plan is at coreos/fedora-coreos-tracker#460.
|
Closing in favour of #1373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to move to a model where networking isn't unconditionally
brought up, but instead only if Ignition requires it.
But I think we'll still have to keep supporting
ignition_network_kcmdlinesince it's kind of part of our API now thatit can be overridden via
ignition.firstboot.Works with:
coreos/fedora-coreos-config#321
coreos/ignition-dracut#164
coreos/ignition#956