This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
pkg/agent: avoid exiting on watch termination #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around coreos#75. Properly, it would also distinguish between "retryable" and "unretryable" errors, but client-go doesn't give us great granularity.
In practice I haven't observed this, but a pod that can't be deleted is no reason to not update.
|
LGTM assuming testing :) |
|
https://quay.io/repository/dghubble/container-linux-update-operator?tab=tags. Dirty to fix the problems in the build scripts #92. |
|
I've tested this on a Kubernetes 1.6.4 cluster today (bare-metal, masked locksmithd) for both update-operator and update-agent. Tested fake D-bus signals and real update_engine updates from an older version of stable, no major regressions. I'll try to post something about this testing process soon, to formalize the process. |
dghubble
approved these changes
Jun 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #75. Properly, it would also distinguish between
"retryable" and "unretryable" errors, but client-go doesn't give us
great granularity.
In the future, adding further granularity would be a good idea.
This also tweaks whether delete failures are fatal based on a discussion @aaronlevy and I had a while ago.
cc @dghubble
Testing done: none yet 😦