Adding CLI for the migration tool #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @chrisohaver @fturib |
fturib
reviewed
Apr 23, 2019
| } | ||
|
|
||
| // defaultCorefileFromPath takes the path where the Corefile is located and checks | ||
| // if the Corefile is the default for a that version of Kubernetes. |
| // defaultCorefileFromPath takes the path where the Corefile is located and checks | ||
| // if the Corefile is the default for a that version of Kubernetes. | ||
| func defaultCorefileFromPath(k8sVersion, corefilePath string) (bool, error) { | ||
| if _, err := os.Stat(corefilePath); os.IsNotExist(err) { |
| Short: "A brief description of your application", | ||
| Long: dedent.Dedent(` | ||
|
|
||
| ┌──────────────────────────────────────────────────────────┐ |
fturib
approved these changes
Apr 23, 2019
chrisohaver
requested changes
Apr 23, 2019
|
|
||
| where `command`, `flags` are: | ||
|
|
||
| - `command`: The operation you want to perform. |
There was a problem hiding this comment.
Need to define what the valid commands are. I think these are in the "Operations" section, but the terminology is not consistent command/operation, so it's confusing.
| where `command`, `flags` are: | ||
|
|
||
| - `command`: The operation you want to perform. | ||
| - `flags` : Specifies flags required to carry out the operations. |
There was a problem hiding this comment.
Need to define what the valid flags are per command.
kubernetes/corefile-tool/README.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| # Migrate CoreDNS from v1.4.0 to v1.5.0 and handle deprecations . |
There was a problem hiding this comment.
Should explain what "handle deprecations" means.
|
Can you also add a wrapper for Released()? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the CLI as defined here
Adds support to basic commands such as
migrate,deprecated,default,removed,unsupportedandvaildversions