-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Support GDPR Compliance #8
(feat): Support GDPR Compliance #8
Conversation
Thanks for the PR @EinfachHans! Is there a reason to require the developer to update |
I was unsure about how to do that based on the variable as we have to set it as an boolean? 🤔 |
@noahcooper other Plugins mostly have scripts for that i think, as |
Yeah, I think the simplest solution will be to use a hook to do this, since I don't think there's any way to use a variable as a Boolean in plugin.xml in this way. I need to think about that a little more. In the meantime, would you mind rebasing with the develop branch to address the merge conflict? And could I bother you to clean up the unnecessary whitespace changes? |
@noahcooper yes hook should work here - For the moment i think the user set this by his own is acceptable. 🤔Merge conflict should be resolved, but i have no idea what is causing these white spaces changes... i rebased and explicit checked in my idea that they are not there and now they are here again? Is that a huge problem? |
@noahcooper okay finally managed my idea to remove the whitespaces |
This looks good. I'll go ahead and merge this as-is, and if I can't get a hook working to update the plist before cutting the next release, that's OK. Thanks for the PR! |
@EinfachHans I've updated the iOS Thanks again for the contribution! |
awesome!! 😊 |
fixes #7
FACEBOOK_AUTO_LOG_EVENTS
VariablesetAutoLogAppEventsEnabled
Method