-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for MULTIPART_PART_HEADERS #452
Conversation
It seems like http.Header is not "sorted". Index for the multiparts headers won't be consistent. |
Codecov ReportBase: 73.10% // Head: 73.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #452 +/- ##
==========================================
+ Coverage 73.10% 73.13% +0.03%
==========================================
Files 143 143
Lines 6584 6593 +9
==========================================
+ Hits 4813 4822 +9
Misses 1494 1494
Partials 277 277
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This makes sense based on the implementation. Do we need them to be consistent? |
Not really, modsecurity doesn't support ordered inputs neither. Unpredictable Hpp could be performed though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
@@ -5,4 +5,4 @@ package types | |||
|
|||
// VariablesCount contains the number of variables handled by the variables package | |||
// It is used to create arrays of the correct size | |||
const VariablesCount = 91 | |||
const VariablesCount = 92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should be generated, what do you think? Wanna give a try @M4tteoP ?
* add support for MULTIPART_PART_HEADERS * Add MULTIPART_PART_HEADERS tests
Add support for MULTIPART_PART_HEADERS
From: https://github.com/SpiderLabs/ModSecurity/releases/tag/v3.0.8
Closes #451