New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds FTW and E2E #56

Merged

jcchavezs merged 3 commits into corazawaf:master from M4tteoP:mage_ftw

Apr 28, 2023

Member

M4tteoP commented Apr 21, 2023 •

edited

Loading

This PR mimics what we have in the proxy/wasm connector to spin up easily and test coraza-caddy: it adds FTW tests, and a complete example deployment with CRS and custom rules to quickly spin up caddy-coraza and play with it.

I currently didn't add FTW to the CI, because I'm experiencing some inconsistent failing tests across different runs :(
An example of a run result is the following:

➕ run 3448 total tests in 40.395347349s
⏭  skipped 4 tests
☝  ignored 62 tests
👎 7 test(s) failed to run: ["920310-3" "920600-13" "920600-15" "921120-3" "942280-2" "942522-5" "980170-2"]
Error: failed 7 tests
[+] Running 7/5

M4tteoP force-pushed the mage_ftw branch 5 times, most recently from 332f6fc to 5812abf Compare

April 24, 2023 16:08

M4tteoP marked this pull request as ready for review

April 24, 2023 16:43

jcchavezs reviewed

View reviewed changes

e2e/e2e-example.sh

@@ @@ -1,19 +1,19 @@ @@
               #!/bin/bash
               # Copyright 2022 The OWASP Coraza contributors
               # SPDX-License-Identifier: Apache-2.0
-              # Copied from https://github.com/corazawaf/coraza-proxy-wasm/tree/main/e2e
-              ENVOY_HOST=${ENVOY_HOST:-"localhost:8080"}
+              # Revisited from https://github.com/corazawaf/coraza-proxy-wasm/tree/main/e2e

Member

jcchavezs Apr 24, 2023

In a next effort we should port this tests to go an reuse across different connectors.

jcchavezs approved these changes

View reviewed changes

M4tteoP changed the title ~~WIP - Adds FTW and mage commands~~ Adds FTW and mage commands

M4tteoP mentioned this pull request

Chore: updates Middleware adding synthesis of Transfer-Encoding header #55

Merged

jcchavezs and others added 3 commits

April 28, 2023 06:51


          feat: aligns plugin logger with zap.


          chore: more tweaks.

1fa33c3


          wip: adds example commands, ftw

5158eaf

jcchavezs force-pushed the mage_ftw branch from 5812abf to 5158eaf Compare

April 28, 2023 04:52

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
3 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

jcchavezs changed the title ~~Adds FTW and mage commands~~ Adds E2E

jcchavezs merged commit 785e584 into corazawaf:master

Member

jcchavezs commented Apr 28, 2023 •

edited

Loading

This is good already. Let's add ftw to the CI in a next PR.

jcchavezs changed the title ~~Adds E2E~~ Adds FTW and E2E

M4tteoP deleted the mage_ftw branch

April 28, 2023 09:00

M4tteoP mentioned this pull request

Adds FTW suite on CI #62

Closed

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet