Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xNetHack reuses the same NETHACKOPTIONS env. variable as NetHack #96

Open
ZzZombo opened this issue Nov 2, 2022 · 4 comments
Open

xNetHack reuses the same NETHACKOPTIONS env. variable as NetHack #96

ZzZombo opened this issue Nov 2, 2022 · 4 comments
Labels
bug savebreakish Not a savebreak but should wait until next version because it breaks something else important

Comments

@ZzZombo
Copy link

ZzZombo commented Nov 2, 2022

I already have NetHack configured using this variable. xNetHack uses the same variable although it's for a different game. It should use only XNETHACKOPTIONS or something for configuration so that separate installations of these games could exist together.
@entrez
Copy link
Contributor

entrez commented Nov 2, 2022 •
edited
Loading

One option would be to use a config file. xNetHack uses ~/.xnethackrc (on Unix, I'm not sure what the file path is on Windows), so it's looking at a different file than NetHack is. Not to say this is a bad suggestion -- just offering an option for now that might help avoid this problem.

@copperwater copperwater added the savebreakish Not a savebreak but should wait until next version because it breaks something else important label Apr 19, 2024
@ZzZombo
Copy link
Author

ZzZombo commented Apr 20, 2024 •
edited
Loading

Could this be given a priority? Now the new release bombs out with unknown settings that previously it didn't, so I need to have the two config. files separate.

@copperwater
Copy link
Owner

copperwater commented Apr 20, 2024 •
edited
Loading

I'm using the new "savebreakish" label to note issues whose fix wouldn't be a savebreak but can possibly be a workflow-break or similar if it were released unexpectedly. I don't want to break things for anyone relying on current behavior of NETHACKOPTIONS so this change will be included in the next version release (9.0).

copperwater added a commit that referenced this issue Jun 24, 2024
@copperwater
Change environment variable for options to XNETHACKOPTIONS
59e4b82 
This avoids a case in which a player was having their environmentally
set NetHack options collide with xNetHack options as both games still
used NETHACKOPTIONS. Since there are a few ways in which NetHack options
can fail to parse in xNetHack (mostly removed ones like roguesymset), it
makes sense to change the environment variable name the game is looking
for.

Closes #96
@copperwater
Copy link
Owner

Compatibility with XNETHACKOPTIONS is now on the 9.0-savebreaking branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug savebreakish Not a savebreak but should wait until next version because it breaks something else important
Projects
xNetHack 9.0 Features
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@copperwater @ZzZombo @entrez