Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native to 0.63.x #723

Closed
alexsegura opened this issue Aug 13, 2020 · 4 comments
Closed

Bump react-native to 0.63.x #723

alexsegura opened this issue Aug 13, 2020 · 4 comments
Labels

Comments

@alexsegura
Copy link
Member

alexsegura commented Aug 13, 2020

This would allow to support dark mode

Needs #722

@alexsegura alexsegura added this to the 1.1.1 milestone Aug 13, 2020
@alexsegura
Copy link
Member Author

There is a problem with React Native 0.63.x → the app can't be bundled for release on iOS.

The following error occurs:

File [...]/CoopCycle.app/main.jsbundle does not exist. 
This must be a bug with React Native, please report it here: https://github.com/facebook/react-native/issues

The actual problem is that, during the Bundle React Native Code And Images build phase, the script to generate the bundle triggers a syntax error:

Capture d’écran 2020-09-05 à 15 37 42

There are some people reporting the same problem

@alexsegura alexsegura reopened this Sep 5, 2020
@alexsegura alexsegura added the ios label Sep 5, 2020
@alexsegura
Copy link
Member Author

The master branch has been reverted to use React Native 0.62

The changes made for 0.63 have been backed up in the bump-rn-63 branch

@alexsegura
Copy link
Member Author

Actually dark mode was fixed here

@alexsegura
Copy link
Member Author

Version 0.63.3 is out, and it seems to fix the issue

alexsegura added a commit that referenced this issue Mar 14, 2021
alexsegura added a commit that referenced this issue Mar 14, 2021
alexsegura added a commit that referenced this issue Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant