Add support for GitLab's new style routes #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can take that risk considering how long it’s been? |
|
I guess they reverted the change |
|
Ping @cookpete |
|
@Reddine Does that mean we are good and can publish this? |
|
that would suggest that we don't need this PR at all, and it shouldn't have been merged. |
No, I mean this change is not needed anymore. |
|
Ah sorry I thought I guess they reverted the change was referring to the change to not redirect from old to new links. No problem. I shall revert 🙃 |
|
Thank you! Sorry for not closing the PR earlier! |
|
No apology needed. Sorry for being a ghost for so long 👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a breaking change for custom or self hosted Gitlab instances that are running old versions, as a solution they can use the override url options.
Closes #266