Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitLab's new style routes #266

Open
Reddine opened this issue May 19, 2023 · 5 comments · May be fixed by #267
Open

Support GitLab's new style routes #266

Reddine opened this issue May 19, 2023 · 5 comments · May be fixed by #267

Comments

@Reddine
Copy link

Reddine commented May 19, 2023

GitLab started moving routes under the - scope around version 12.0. You can find more information about this change in the GitLab issue #28848.

Paths without the - are considered legacy and can be found in older versions. Starting from version 16, which was released yesterday (May 18, 2023) GitLab FOSS Changelog, all group/project routes are only accessible through the /-/ path.

This change has affected the generated autochangelog for projects that use GitLab. Users will encounter an HTTP error 404 - Page Not Found when accessing these routes.
@Reddine Reddine linked a pull request May 19, 2023 that will close this issue
Open
@ljharb
Copy link
Contributor

ljharb commented May 19, 2023

Cool URLs don't change; if a link that used to work stops working then GitLab has broken one of the core principles of the web - or are you saying that new links don't work, and the autogeneration is producing the old style?

@Reddine
Copy link
Author

Reddine commented May 19, 2023 •
edited
Loading

Yes, they used to function properly due to the redirection to the corresponding new links, but that is no longer the case since version 16.0.

The autogenearation is producing the old style which were defined as legacy URLs.

According to the release notes it seems a necessitated choice! I quote from https://gitlab.com/gitlab-org/gitlab/-/issues/28848:

We are removing legacy URLs from the GitLab application. The introduction of subgroups in GitLab 9.0 necessitated that we use a /-/ delimiter in URLs to signify the end of a group path. More information about this change can be found at #214217. Since then, we've been consolidating all of the URLs in GitLab to use this delimiter for project, group, and instance-level features. URLs which do not use the delimiter are being removed in GitLab 16.0 in favor of those that do.

@ljharb
Copy link
Contributor

ljharb commented May 19, 2023

That's not how URLs are supposed to work; old URLs are never supposed to stop working.

@Reddine
Copy link
Author

Reddine commented May 19, 2023

I agree but unfortunately it's happening source

@rpong rpong mentioned this issue May 24, 2023
Open
@Reddine
Copy link
Author

Reddine commented May 25, 2023

Gitlab returned the redirection, it seems to work fine now!
Discussion can be followed on https://gitlab.com/gitlab-org/gitlab/-/issues/412435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for GitLab's new style routes Reddine/auto-changelog
2 participants
@ljharb @Reddine