Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError [ERR_INVALID_URL]: Invalid URL #249

Closed
thisVioletHydra opened this issue Nov 16, 2022 · 3 comments · Fixed by #289
Closed

TypeError [ERR_INVALID_URL]: Invalid URL #249

thisVioletHydra opened this issue Nov 16, 2022 · 3 comments · Fixed by #289

Comments

@thisVioletHydra
Copy link

yarn run v1.22.19
$ yarn npm-run-all run:push::*
$ C:\www\project\node_modules\.bin\npm-run-all run:push::*
$ auto-changelog -p && git add CHANGELOG.md


TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:393:5)
    at getHostname (node:url:521:15)
    at Url.parse (node:url:390:14)
    at Object.urlParse [as parse] (node:url:147:13)
    at parse (C:\www\project\node_modules\parse-github-url\index.js:34:20)
    at parseGithubUrl (C:\www\project\node_modules\parse-github-url\index.js:14:38)
    at getRemote (C:\www\project\node_modules\auto-changelog\src\remote.js:24:18)
    at fetchRemote (C:\www\project\node_modules\auto-changelog\src\remote.js:6:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getOptions (C:\www\project\node_modules\auto-changelog\src\run.js:73:18) {
  input: 'http://git@git.__long__name__/project.git\n',
  code: 'ERR_INVALID_URL'
}
error Command failed with exit code 1.
@bangbang93
Copy link

The same in node v19.1.0, and works fine in node v18.12.1

@ljharb
Copy link
Contributor

ljharb commented Nov 22, 2022

This is a node bug that will be fixed in the next node 19. It breaks parse-github-url.

@ljharb
Copy link
Contributor

ljharb commented Apr 20, 2023

Here's the deprecation message printed on node 20:

auto-changelog: Fetching tags…(node:89474) [DEP0170] DeprecationWarning: The URL http://git@github.com:es-shims/iterator-helpers.git
 is invalid. Future versions of Node.js will throw an error.

This does need to be fixed (cc @cookpete)

JHyeok added a commit to JHyeok/auto-changelog that referenced this issue Aug 12, 2024
cookpete pushed a commit that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants