Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for image type asset #27

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

Jayesh2812
Copy link
Contributor

Added support to render image when asset is of image type with the following optional paramters.

  1. Alt text
  2. Caption
  3. Embed Link
  4. Opening in new tab if embed link is provided
  5. Alignment
  6. Inline

@Jayesh2812 Jayesh2812 requested a review from a team as a code owner October 30, 2023 10:35
@Jayesh2812 Jayesh2812 force-pushed the CS-42158--support-for-image-assets branch from 70d3af4 to fd93a17 Compare November 1, 2023 05:21
src/toRedactor.tsx Outdated Show resolved Hide resolved
}
delete styleObj['float']
attrsJson["style"] = getStyleStringFromObject(styleObj);
console.dir({jsonValue, attrsJson, figureStyles, styleObj}, {depth:null})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done

src/toRedactor.tsx Outdated Show resolved Hide resolved
src/toRedactor.tsx Outdated Show resolved Hide resolved
src/toRedactor.tsx Outdated Show resolved Hide resolved
KANE-99
KANE-99 previously approved these changes Nov 2, 2023
Copy link

@KANE-99 KANE-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just check one comment.

@Jayesh2812 Jayesh2812 changed the base branch from master to development November 2, 2023 05:49
Copy link

@KANE-99 KANE-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jayesh2812 Jayesh2812 merged commit 1070af5 into development Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants