import pre setup command base code #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport-setup-command
…li into feat/import-setup-command
shafeeqd959
changed the base branch from
development
to
feat/import-setup-command-base
shafeeqd959
requested review from
sunil-lakshman,
cs-raj,
aman19K and
netrajpatel
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
@shafeeqd959 what purpose we used this empty object file.
There was a problem hiding this comment.
Will add messages in future commits
aman19K
reviewed
Sep 4, 2024
| "dependencies": { | ||
| "@contentstack/cli-command": "~1.3.0", | ||
| "@contentstack/cli-utilities": "~1.7.1", | ||
| "@contentstack/management": "~1.17.0", |
There was a problem hiding this comment.
@shafeeqd959 , Since we're using cli-utilities, so management sdk isn't required here
There was a problem hiding this comment.
Will remove in the upcoming commits
Comment on lines
+1
to
+21
| export const formatError = (error: any) => { | ||
| try { | ||
| if (typeof error === 'string') { | ||
| error = JSON.parse(error); | ||
| } else { | ||
| error = JSON.parse(error.message); | ||
| } | ||
| } catch (e) {} | ||
| let message = error?.errorMessage || error?.error_message || error?.message || error; | ||
| if (error && error.errors && Object.keys(error.errors).length > 0) { | ||
| Object.keys(error.errors).forEach((e) => { | ||
| let entity = e; | ||
| if (e === 'authorization') entity = 'Management Token'; | ||
| if (e === 'api_key') entity = 'Stack API key'; | ||
| if (e === 'uid') entity = 'Content Type'; | ||
| if (e === 'access_token') entity = 'Delivery Token'; | ||
| message += ' ' + [entity, error.errors[e]].join(' '); | ||
| }); | ||
| } | ||
| return message; | ||
| }; |
There was a problem hiding this comment.
@shafeeqd959 , We can utilise formatError, which we created in utilities.
There was a problem hiding this comment.
will use it in the upcoming commits
aman19K
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.