Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(draft-mode): support guest space with draft mode #99

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(draft-mode): support guest space with draft mode #99

merged 2 commits into from
Aug 8, 2023

Conversation

chrishelgert
Copy link
Contributor

@chrishelgert chrishelgert commented Aug 1, 2023 •
edited
Loading

What will change?

  • The blog template switched over to the draft mode of vercel
  • If you enable the draft mode, you will loose the information of the guest space
  • With this changes it's now possible to have draft mode and guest space

@chrishelgert chrishelgert requested a review from a team as a code owner August 1, 2023 11:02
@vercel
Copy link

vercel bot commented Aug 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
template-blog-webapp-nextjs ✅ Ready (Inspect) Visit Preview Aug 8, 2023 0:11am

@chrishelgert chrishelgert force-pushed the PRIVATE-BRANCH_guest-space-draft-mode branch from 0d8c8ab to 222f482 Compare August 7, 2023 13:16
@chrishelgert chrishelgert force-pushed the PRIVATE-BRANCH_guest-space-draft-mode branch from 222f482 to 32a5427 Compare August 7, 2023 13:17
stephanLeece
stephanLeece approved these changes Aug 7, 2023
View reviewed changes
Copy link

@stephanLeece stephanLeece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrishelgert chrishelgert requested a review from a team August 7, 2023 14:03
@chrishelgert chrishelgert enabled auto-merge (squash) August 8, 2023 12:10
@chrishelgert chrishelgert merged commit 720470a into main-private Aug 8, 2023
1 check passed
@chrishelgert chrishelgert deleted the PRIVATE-BRANCH_guest-space-draft-mode branch August 8, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YvesRijckaert YvesRijckaert YvesRijckaert approved these changes

@stephanLeece stephanLeece stephanLeece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrishelgert @YvesRijckaert @stephanLeece