Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates avatar design and variations #2858

Merged
merged 27 commits into from
Sep 12, 2024

Conversation

Lelith
Copy link
Collaborator

@Lelith Lelith commented Sep 3, 2024

What changed?

  • Contrast borders are used by default
  • Legacy default border is not available anymore
  • Gray (default) border is thin (1px) while colored borders are thicker (2px)
  • Muted colors are now 50% opacity on white background, including the border. If we use the avatar on non-white background, we don't want to see that background color. For that reason, I use color-mix with 50% white.

Screenshots

image

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Sep 12, 2024 8:11am

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 03a9724

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@contentful/f36-avatar Minor
@contentful/f36-components Minor
@contentful/f36-navbar Minor
@contentful/f36-accordion Minor
@contentful/f36-asset Minor
@contentful/f36-autocomplete Minor
@contentful/f36-badge Minor
@contentful/f36-button Minor
@contentful/f36-card Minor
@contentful/f36-collapse Minor
@contentful/f36-copybutton Minor
@contentful/f36-core Minor
@contentful/f36-datetime Minor
@contentful/f36-datepicker Minor
@contentful/f36-drag-handle Minor
@contentful/f36-entity-list Minor
@contentful/f36-empty-state Minor
@contentful/f36-forms Minor
@contentful/f36-icon Minor
@contentful/f36-header Minor
@contentful/f36-list Minor
@contentful/f36-menu Minor
@contentful/f36-modal Minor
@contentful/f36-note Minor
@contentful/f36-notification Minor
@contentful/f36-pagination Minor
@contentful/f36-pill Minor
@contentful/f36-popover Minor
@contentful/f36-skeleton Minor
@contentful/f36-spinner Minor
@contentful/f36-table Minor
@contentful/f36-tabs Minor
@contentful/f36-text-link Minor
@contentful/f36-tooltip Minor
@contentful/f36-typography Minor
@contentful/f36-image Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 111.8 KB (-0.16% 🔽) 2.3 s (-0.16% 🔽) 1.3 s (+2.57% 🔺) 3.5 s
Module 110.74 KB (+0.1% 🔺) 2.3 s (+0.1% 🔺) 1.5 s (+6.41% 🔺) 3.7 s

@andipaetzold andipaetzold self-assigned this Sep 3, 2024
@damann
Copy link

damann commented Sep 5, 2024

Tiny muted doesn't have a border

Why did we decide to remove the border from tiny? FWIW I'm thinking about removing the tiny variant all together (in a follow up).

<Avatar {...args} size="large" variant="app" colorVariant="lavender" />
<Avatar {...args} size="large" variant="app" colorVariant="emerald" />
</Flex>

<SectionHeading as="h4">Tooltip properties</SectionHeading>
<SectionHeading as="h3" marginBottom="spacingS">
Tooltip properties
Copy link
Collaborator

@denkristoffer denkristoffer Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andipaetzold Can we force this tooltip open for the Chromatic snapshot?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to technically achieve that.

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Avatar looks bad on the old navigation, should we merge this to next and release an alpha?

https://5fd1dda724cc620021ace8c5-oxrqgsaxju.chromatic.com/?path=/story/components-navbar--basic

@andipaetzold andipaetzold enabled auto-merge (squash) September 12, 2024 08:06
@andipaetzold andipaetzold merged commit 7821bd3 into main Sep 12, 2024
15 checks passed
@andipaetzold andipaetzold deleted the feat/update_avatar_design_CFISO-1679 branch September 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants