-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates avatar design and variations #2858
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 03a9724 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
yellow -> gold pink -> strawberry olive -> emerald
Why did we decide to remove the border from tiny? FWIW I'm thinking about removing the tiny variant all together (in a follow up). |
To make this PR non-breaking
<Avatar {...args} size="large" variant="app" colorVariant="lavender" /> | ||
<Avatar {...args} size="large" variant="app" colorVariant="emerald" /> | ||
</Flex> | ||
|
||
<SectionHeading as="h4">Tooltip properties</SectionHeading> | ||
<SectionHeading as="h3" marginBottom="spacingS"> | ||
Tooltip properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andipaetzold Can we force this tooltip open for the Chromatic snapshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to technically achieve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Avatar looks bad on the old navigation, should we merge this to next
and release an alpha?
https://5fd1dda724cc620021ace8c5-oxrqgsaxju.chromatic.com/?path=/story/components-navbar--basic
We are fine releasing the PR as 4.x
This reverts commit 21291a3.
What changed?
Screenshots