Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE ] feat: next #2828

Draft
wants to merge 151 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE ] feat: next #2828

wants to merge 151 commits into from

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Jul 17, 2024 •
edited
Loading

Working branch for the alpha version of the following packages:

  • codemod (icons v4 > v5)
  • icon
  • icons
  • navbar
  • layout

@cf-remylenoir cf-remylenoir added breaking change Used to mark when a proposal includes breaking changes, therefore it needs a plan for release don't merge labels Jul 17, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Sep 12, 2024 2:37pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d527998

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 516.97 KB (+277.93% 🔺) 10.4 s (+277.93% 🔺) 513 ms (+110.61% 🔺) 10.9 s
Module 512.57 KB (+285.32% 🔺) 10.3 s (+285.32% 🔺) 736 ms (+178.31% 🔺) 11 s

@Lelith Lelith changed the title feat: next [DO NOT MERGE ] feat: next Jul 31, 2024
@andipaetzold
feat(navbar): various navbar spacing tweaks (#2855)
dc9ba87 
* feat(navbar): various navbar spacing tweaks

* fix: add box-sizing

* fix: change switcher skeleton radius

* fix: use `SkeletonText` instead of `SkeletonDisplayText`

* fix: do not wrap `SwitcherSkeleton` in `Switcher`

* chore: release new navbar version
@Lelith
feat: add tooltip for icon only nav items cfiso 1677 (#2851)
e25956b 
* feat: render tooltip for icon only navbar items

* fix: height of icon only item

* feat: enable tooltip on avatar

* feat: adjust hover filter on account avatar

* feat: enable setting of aria label and tooltip

* fix: focus glow border was not round

* chore: update story

* chore: release version 5.0.0-alpha.31 of navbar
massao and others added 2 commits September 9, 2024 14:06
@massao
feat: add environment to navbar switcher (#2857)
64d2a58 
* feat: add environment to navbar switcher

* refactor: improve env color check

* refactor: improve types and fix typo

* refactor: update color of caret icon
@massao
chore: publish new navbar alpha version
d752603
@Lelith
fix: add fixed height to navbar (#2862)
f794fd0 
* chore: set and export fixed height

* refactor: export from own file

* chore: release "5.0.0-alpha.36"
@andipaetzold
fix(navbar): unpin avatar dep (#2873)
cfc8d65 
* chore: npm install

* fix(navbar): unpin avatar dep

* chore: release new navbar version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damann damann Awaiting requested review from damann damann will be requested when the pull request is marked ready for review damann is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@denkristoffer denkristoffer

@massao massao

@Lelith Lelith

@stephanLeece stephanLeece

@cf-remylenoir cf-remylenoir

Labels
breaking change Used to mark when a proposal includes breaking changes, therefore it needs a plan for release don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cf-remylenoir @denkristoffer @massao @Lelith @stephanLeece @bgutsol @YvesRijckaert @cpesket @andipaetzold