build: switch to dual package emitting #2746
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "main": "./dist/cjs/index.js", | ||
| "module": "./dist/esm/index.js", | ||
| "types": "./dist/esm/index.d.ts", |
There was a problem hiding this comment.
For backward compability
cf-remylenoir
force-pushed
the
dual-package-emit
branch
from
79d89ad
to
ed88749
Compare
cf-remylenoir
force-pushed
the
dual-package-emit
branch
from
c9aaf4b
to
ff61b51
Compare
cf-remylenoir
requested review from
stephanLeece,
denkristoffer and
andipaetzold
and removed request for
a team,
damann and
stephanLeece
| "sideEffects": false, | ||
| "type": "module", | ||
| "main": "./dist/cjs/index.js", |
There was a problem hiding this comment.
type: module & main being CJS seems wrong
| "engines": { | ||
| "node": ">=16" |
There was a problem hiding this comment.
Why is this required? It's a frontend package.
There was a problem hiding this comment.
It isn't, to be removed.
Purpose of PR
Note
This is only for v5 alpha/beta pre-releases and won't be merged into
mainAdds setup for emitting 2 package.json files for ESM and CJS, making use of tsconfig-to-dual-package.
This approach has the benefit of clearly declaring what type should be used since it relies on 2 package.json and prevents Node/TypeScript configuration confusion or change for the consumers, and mostly issues with our direct dependency for the icons (Phosphor)
Motivation and readings 🍿
.tsmicrosoft/TypeScript#49462