Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-should-include-tests: no more CI:DOCS override #23225

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

edsantiago
Copy link
Member

CI:DOCS is no more.

Signed-off-by: Ed Santiago santiago@redhat.com

None

CI:DOCS is no more.

Signed-off-by: Ed Santiago <santiago@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we redefine the rules to better match our cirrus rules?
I think we could easily say unless a .go or .c was changed and not only in vendor/ or test/ then we do not need a test. To me this would help here to simply file the large
filtered_changes list

@edsantiago
Copy link
Member Author

Possibly. I would need a thorough review of exceptions, such as .conf files, or pkg/*/json-and-yaml-and-zip, and probably add .s even though there are no such files today.

Also, in the process of looking into this, I realized you need to add *.h to your changesInclude()

I'm OOTO today, will think about it more tomorrow. Thanks for the suggestion.

@Luap99
Copy link
Member

Luap99 commented Jul 9, 2024

I realized you need to add *.h to your changesInclude()

I didn't though about .h because I thought all the symbol definitions are done in the go file in the special c comments but looks like you are right we have one .h file. I spin up a PR to add it.

@mheon
Copy link
Member

mheon commented Jul 9, 2024

This PR LGTM

@lsm5
Copy link
Member

lsm5 commented Jul 16, 2024

/packit rebuild

@baude
Copy link
Member

baude commented Aug 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bd53a11 into containers:main Aug 12, 2024
90 checks passed
@edsantiago edsantiago deleted the no-more-ci-docs branch August 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants