Skip to content

Commit

Permalink
Merge pull request #23225 from edsantiago/no-more-ci-docs
Browse files Browse the repository at this point in the history
pr-should-include-tests: no more CI:DOCS override
  • Loading branch information
openshift-merge-bot[bot] authored Aug 12, 2024
2 parents 6738405 + 5e9ab00 commit bd53a11
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions contrib/cirrus/pr-should-include-tests
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ ME=$(basename $0)
# Github label which allows overriding this check
OVERRIDE_LABEL="No New Tests"

# Docs-only changes are excused
if [[ "${CIRRUS_CHANGE_TITLE}" =~ CI:DOCS ]]; then
exit 0
fi

# HEAD should be good enough, but the CIRRUS envariable allows us to test
head=${CIRRUS_CHANGE_IN_REPO:-HEAD}
# Base of this PR. Here we absolutely rely on cirrus.
Expand Down
2 changes: 1 addition & 1 deletion contrib/cirrus/pr-should-include-tests.t
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function run_test_script() {
testnum=$(( testnum + 1 ))

CIRRUS_CHANGE_TITLE="[CI:DOCS] hi there" $test_script &>/dev/null
if [[ $? -ne 0 ]]; then
if [[ $? -ne 1 ]]; then
echo "not ok $testnum $rest (override with CI:DOCS)"
rc=1
else
Expand Down

0 comments on commit bd53a11

Please sign in to comment.