Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failing: remote build filtering: timeout in dd #15014

Closed
edsantiago opened this issue Jul 21, 2022 · 6 comments
Closed

test failing: remote build filtering: timeout in dd #15014

edsantiago opened this issue Jul 21, 2022 · 6 comments
Assignees
@flouthoc
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Test is failing in f36 even though the PR in question has nothing to do with new f36 images:

Remote build .containerignore filtering embedded directory (#13535)
...
Timed out after 10.000s.

The timeout is here https://github.com/containers/podman/blob/b5612df55060317bcef92de48e5b2cd400374814/test/e2e/build_test.go#L555-L558

I do see the following output in the log:

 1+0 records in
 1+0 records out
 1073741824 bytes (1.1 GB, 1.0 GiB) copied, 13.2489 s, 81.0 MB/s
@edsantiago edsantiago added the kind/bug Categorizes issue or PR as related to a bug. label Jul 21, 2022
@edsantiago
Copy link
Member Author

Important note about this one: the original test dd'ed from /dev/random, which is inappropriate. I switched to urandom but the test is still timing out.

@edsantiago edsantiago mentioned this issue Jul 21, 2022
Merged
edsantiago added a commit to edsantiago/libpod that referenced this issue Jul 22, 2022
@edsantiago
Bump VMs, to Ubuntu 2204 with cgroups v1
0a160fe 
...and enable the at-test-time confirmation, the one that
double-checks that if CI requests runc we actually use runc.
This exposed a nasty surprise in our setup: there are steps to
define $OCI_RUNTIME, but that's actually a total fakeout!
OCI_RUNTIME is used only in e2e tests, it has no effect
whatsoever on actual podman itself as invoked via command
line such as in system tests. Solution: use containers.conf

Given how fragile all this runtime stuff is, I've also added
new tests (e2e and system) that will check $CI_DESIRED_RUNTIME.

Image source: containers/automation_images#146

Since we haven't actually been testing with runc, we need
to fix a few tests:

  - handle an error-message change (make it work in both crun and runc)
  - skip one system test, "survive service stop", that doesn't
    work with runc and I don't think we care.

...and skip a bunch, filing issues for each:

  - containers#15013 pod create --share-parent
  - containers#15014 timeout in dd
  - containers#15015 checkpoint tests time out under $CONTAINER
  - containers#15017 networking timeout with registry
  - containers#15018 restore --pod gripes about missing --pod
  - containers#15025 run --uidmap broken
  - containers#15027 pod inspect cgrouppath broken
  - ...and a bunch more ("podman pause") that probably don't
    even merit filing an issue.

Also, use /dev/urandom in one test (was: /dev/random) because
the test is timing out and /dev/urandom does not block. (But
the test is still timing out anyway, even with this change)

Also, as part of the VM switch we are now using go 1.18 (up
from 1.17) and this broke the gitlab tests. Thanks to @Luap99
for a quick fix.

Also, slight tweak to containers#15021: include the timeout value, and
reword message so command string is at end.

Also, fixed a misspelling in a test name.

Fixes: containers#14833

Signed-off-by: Ed Santiago <santiago@redhat.com>
@jwhonce jwhonce assigned flouthoc and unassigned jwhonce Jul 28, 2022
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

I'm not even seeing this in my flake logs - maybe it only flaked in that one PR. If I see it again, I'll reopen.

@edsantiago edsantiago mentioned this issue Jan 9, 2023
Closed
@edsantiago edsantiago added the jetsam "...cargo that is cast overboard to lighten the load in time of distress" label Jan 10, 2023
@edsantiago
Copy link
Member Author

Nope, bug is still present. Leaving closed, but marking as jetsam

edsantiago added a commit to edsantiago/libpod that referenced this issue Jan 10, 2023
@edsantiago
Tests: remove/update obsolete skips
4612125 
To silence my find-obsolete-skips script:
 - containers#11784 : issue closed wont-fix
 - containers#15013 : issue closed, we no longer test with runc
 - containers#15014 : bump timeout, see if that fixes things
 - containers#15025 : issue closed, we no longer test with runc

...and one FIXME not associated with an issue, ubuntu-related,
and we no longer test ubuntu.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago
Copy link
Member Author

Reopening. Leaving this Skip in place led to a regression, see #17059

@edsantiago edsantiago reopened this Jan 11, 2023
edsantiago added a commit to edsantiago/libpod that referenced this issue Jan 19, 2023
@edsantiago
e2e tests: reenable long-skipped build test
51836aa 
July 2022: test was flaking on new VM images. We needed new
images, so I filed containers#15014 and skipped the test.

January 2023: no attention from anyone, so I'll try bumping up
a dd timeout from 10s to 30s. But in the interim, the test
has broken: it used to expect "Containerfile" in output (this
was deliberately added in containers#13655)... but containers#16810 changed that
so Containerfile no longer appears. @flouthoc argues that
this too is deliberate (containers#17059). Okay, so let's change the
test then. All I care about is not adding more regressions.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago edsantiago mentioned this issue Jan 19, 2023
Merged
@edsantiago
Copy link
Member Author

#17164 removed the Skip(). The test has been running, and passing, with the 30-second timeout. I consider this closed.

@edsantiago edsantiago removed the jetsam "...cargo that is cast overboard to lighten the load in time of distress" label Oct 31, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flouthoc flouthoc

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@edsantiago @jwhonce @rhatdan @flouthoc