-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 64bit rdev APIs #329
Add 64bit rdev APIs #329
Conversation
Pairs with containers#329 which adapts the C side to properly accept these too. This breaks semver, we'll need to bump that. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could use a macro to direct users towards the new variant on recompile, dropping the old declaration from the headers (but keeping it defined to avoid breaking ABI). Would save some churn...
But if any callers had been interacting with this via |
I stumbled across the fact that on Linux/glibc at least `dev_t` is 64 bits, but we were truncating it to 32 bits. Note that the type used in the `mkcomposefs` binary was already uint64_t but because C happily truncates/converts integers this was missed. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I stumbled across the fact that on Linux/glibc at least
dev_t
is 64 bits, but we were truncating it to 32 bits.Note that the type used in the
mkcomposefs
binary was already uint64_t but because C happily truncates/converts integers this was missed.