install: Drop SELinux-disabled warning #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have e2e tests for this today. On a related topic, unfortunately the way bootc-image-builder sets up the container it runs bootc in it doesn't mount selinuxfs, so we see SELinux as disabled when it's not. We should fix that, but it also avoids user confusion to drop the warning here. While we're here, change things so we more consistently log the state computed. Closes: containers#419 Signed-off-by: Colin Walters <walters@verbum.org>
mvo5
approved these changes
Sep 18, 2024
I think so yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have e2e tests for this today. On a related topic, unfortunately the way bootc-image-builder sets up the container it runs bootc in it doesn't mount selinuxfs, so we see SELinux as disabled when it's not.
We should fix that, but it also avoids user confusion to drop the warning here.
While we're here, change things so we more consistently log the state computed.
Closes: #419