Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macvtap plugin #316

Closed
wants to merge 3 commits into from
Closed

Macvtap plugin #316

wants to merge 3 commits into from

Conversation

rmohr
Copy link

@rmohr rmohr commented Oct 31, 2016

Code to discuss #315.

@rmohr rmohr mentioned this pull request Oct 31, 2016
@rmohr rmohr force-pushed the macvtap branch 2 times, most recently from f6442a7 to 9b82079 Compare October 31, 2016 11:10
@rosenhouse
Copy link
Contributor

Hi @rmohr: thanks for taking the time to put this together. It looks really interesting and it's great to see new types of CNI plugins!

I'd point you to our Acceptance Policy. In particular:

@leodotcloud
Copy link

leodotcloud commented Dec 19, 2016

@rosenhouse This is a generic plugin similar to the already available macvlan/ipvlan plugins. It's not a third party plugin. So I think it should be ok to not have a separate repo for this.

Or does it makes sense to separate the generic plugins of CNI into a separate repo to keep the SPEC and core functionality in the cni repo?

@squeed
Copy link
Member

squeed commented Jun 8, 2017

Reviving this:

  1. Are any spec changes still proposed?
  2. There may be a use for a kvm hierarchy in the plugins repository. If you like, you may wish to open a PR there.

@rosenhouse
Copy link
Contributor

All CNI plugins maintained by the CNI team have moved to https://github.com/containernetworking/plugins

If you'd still like to contribute this to the CNI project, please open a new PR there, and we can discuss. Closing this one.

@rosenhouse rosenhouse closed this Aug 30, 2017
maiqueb added a commit to maiqueb/macvtap-cni that referenced this pull request Dec 4, 2019
Minimalistic rebase of [0].

The development of this CNI pluging will be devoloped mainly in
this public personal repo, until the code is ready to be
contributed back to either cni project - [1] - or kubevirt - [2] -
project.

TODO:
  - ipam
  - CmdCheck implementation

[0] - containernetworking/cni#316
[1] - https://github.com/containernetworking/plugins
[2] - https://github.com/kubevirt/

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants