-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macvtap plugin #316
Macvtap plugin #316
Conversation
f6442a7
to
9b82079
Compare
Hi @rmohr: thanks for taking the time to put this together. It looks really interesting and it's great to see new types of CNI plugins! I'd point you to our Acceptance Policy. In particular:
|
TODO Tests TODO Documentation
@rosenhouse This is a generic plugin similar to the already available macvlan/ipvlan plugins. It's not a third party plugin. So I think it should be ok to not have a separate repo for this. Or does it makes sense to separate the generic plugins of CNI into a separate repo to keep the SPEC and core functionality in the cni repo? |
Reviving this:
|
All CNI plugins maintained by the CNI team have moved to https://github.com/containernetworking/plugins If you'd still like to contribute this to the CNI project, please open a new PR there, and we can discuss. Closing this one. |
Minimalistic rebase of [0]. The development of this CNI pluging will be devoloped mainly in this public personal repo, until the code is ready to be contributed back to either cni project - [1] - or kubevirt - [2] - project. TODO: - ipam - CmdCheck implementation [0] - containernetworking/cni#316 [1] - https://github.com/containernetworking/plugins [2] - https://github.com/kubevirt/ Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Code to discuss #315.