New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make working on arm64 and ppc64le too #209

Closed

luxas opened this issue May 17, 2016 · 8 comments

Labels

area/developer tooling component/plugins kind/enhancement

Milestone

Contributor

luxas commented May 17, 2016

When building for arm64 or ppc64le, it fails with these messages:

# github.com/containernetworking/cni/pkg/ns
pkg/ns/ns.go:26: undefined: setNsNr
# github.com/containernetworking/cni/vendor/golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/flock.go:18: undefined: Flock_t
vendor/golang.org/x/sys/unix/sockcmsg_linux.go:14: undefined: Ucred
vendor/golang.org/x/sys/unix/sockcmsg_linux.go:27: undefined: Ucred
vendor/golang.org/x/sys/unix/sockcmsg_unix.go:42: undefined: Cmsghdr

The ns.go issue seems easy to fix, but the golang.org/x/sys/unix ones seems harder.
We'll need cni for these arches for Kubernetes

The text was updated successfully, but these errors were encountered:

Contributor Author

luxas commented May 17, 2016

Contributor Author

luxas commented May 17, 2016

The first one is easy, we just need to create some more files: https://github.com/opencontainers/runc/blob/master/libcontainer/system/setns_linux.go#L13-22

Contributor Author

luxas commented May 17, 2016 •

edited

Loading

Checked the golang.org/x/sys dependency out and it's really old. Now the package has 155 commits, the vendored version has only 76, so only a godep update will do

steveej modified the milestone: v1.0.0

Member

steveej commented May 19, 2016

@luxas please submit a PR with the mentioned godep update. In the longterm we might want to include compilation for other architectures in our CI. For this purpose it would be shared the build steps, unless you're building this natively ;-)

steveej added area/developer tooling kind/enhancement component/plugins labels

Contributor Author

luxas commented May 24, 2016

I'm cross-compiling, and will send a PR as soon as I have time :)

Contributor Author

luxas commented Jun 8, 2016

Seems like c0d34c6 fixed the SetNsNr issue.
I'm sending a PR now...

Contributor Author

luxas commented Jun 8, 2016

#241
I think you can move this to v0.4.0

luxas added a commit to luxas/cni that referenced this issue


          vendor: Bump golang.org/x/sys/unix to a newer version

5006aac

The current vendor of sys/unix is really old, and doesn't work on arm64 and ppc64le
Updating to the latest version might also fix other issues

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          build: Update the build script to make it possible to build for other…

273b9ab

… architectures

This makes it possible to cross-compile cni like so:
$ GOARCH=arm ./build
$ GOARCH=arm64 ./build
$ GOARCH=ppc64le ./build

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          travis: Cross-compile for arm, arm64 and ppc64le on every build

cffce09

Cross-compile cni for arm, arm64 and ppc64le with go1.6 only
Allow go tip to fail
Set fast_finish to true, which means travis will instantly return build failure when any of the required builds fail

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          release: Release binaries for arm, arm64 and ppc64le too

a5e149b

Modify the releasing script to cross-compile for the new architectures, but also keep backwards-compability

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          vendor: Bump golang.org/x/sys/unix to a newer version

0f79cf2

The current vendor of sys/unix is really old, and doesn't work on arm64 and ppc64le
Updating to the latest version might also fix other issues

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          build: Update the build script to make it possible to build for other…

6b753b3

… architectures

This makes it possible to cross-compile cni like so:
$ GOARCH=arm ./build
$ GOARCH=arm64 ./build
$ GOARCH=ppc64le ./build

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          travis: Cross-compile for arm, arm64 and ppc64le on every build

817061d

Cross-compile cni for arm, arm64 and ppc64le with go1.6 only
Allow go tip to fail
Set fast_finish to true, which means travis will instantly return build failure when any of the required builds fail

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          release: Release binaries for arm, arm64 and ppc64le too

72e203e

Modify the releasing script to cross-compile for the new architectures, but also keep backwards-compability

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          vendor: Bump golang.org/x/sys/unix to a newer version

488db88

The current vendor of sys/unix is really old, and doesn't work on arm64 and ppc64le
Updating to the latest version might also fix other issues

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          build: Update the build script to make it possible to build for other…

fc58b79

… architectures

This makes it possible to cross-compile cni like so:
$ GOARCH=arm ./build
$ GOARCH=arm64 ./build
$ GOARCH=ppc64le ./build

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          travis: Cross-compile for arm, arm64 and ppc64le on every build

21d2595

Cross-compile cni for arm, arm64 and ppc64le with go1.6 only
Allow go tip to fail
Set fast_finish to true, which means travis will instantly return build failure when any of the required builds fail

ref containernetworking#209

luxas added a commit to luxas/cni that referenced this issue


          release: Release binaries for arm, arm64 and ppc64le too

39f8436

Modify the releasing script to cross-compile for the new architectures, but also keep backwards-compability

ref containernetworking#209

Contributor Author

luxas commented Oct 2, 2016

This is working now when #241 is merged. Thanks!

luxas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment