Add Inspect image #239
Add Inspect image #239
Conversation
fahedouch
force-pushed
the
inspect-image
branch
2 times, most recently
from
bfa9d38
to
4d8a1c7
Compare
pkg/inspecttypes/native/image.go
Outdated
| // Not compatible with `docker image inspect`. | ||
| type Image struct { | ||
| images.Image | ||
| ImageSpec interface{} `json:"Image"` |
There was a problem hiding this comment.
@AkihiroSuda interface{}. because i want to avoid using the ocispec.Image in this native containerd object
There was a problem hiding this comment.
Why do you want to avoid it?
There was a problem hiding this comment.
it looks cleaner if i use an interface here and map this interface to ocispec.Image in dockercompat may be I'm wrong. Anyway I made the change
image_inspect.go
Outdated
| defaultBashComplete(clicontext) | ||
| return | ||
| } | ||
| // show container names |
inspect.go
Outdated
| } | ||
|
|
||
| if ni != 0 && nc != 0 { | ||
| return errors.Errorf("Multiple IDs found with provided prefix: %s", req) |
There was a problem hiding this comment.
error should start with a lower char
|
|
||
| i.ID = n.Descriptor.Digest.String() | ||
|
|
||
| s := []string{n.Image.Name, "@", n.Image.Target.Digest.String()} |
| i.ID = n.Descriptor.Digest.String() | ||
|
|
||
| s := []string{n.Image.Name, "@", n.Image.Target.Digest.String()} | ||
| i.RepoTags, i.RepoDigests = parseImageReferences([]string{strings.Join(s, "")}) |
There was a problem hiding this comment.
We already know the digest, no need to "parse" it
pkg/imageinspector/imageinspector.go
Outdated
| } | ||
|
|
||
| n.Descriptor = config | ||
| n.Image.Name = image.Name |
There was a problem hiding this comment.
Why not just set n.Image = image
fahedouch
force-pushed
the
inspect-image
branch
4 times, most recently
from
b53f984
to
5e4b918
Compare
| } | ||
|
|
||
| var tag string | ||
| nameWithTagSplit := strings.Split(imgName, ":") |
There was a problem hiding this comment.
There was a problem hiding this comment.
(I noticed that the code is not new in this PR, so this can be done later)
| } | ||
| repository := strings.TrimSuffix(imgName, ":"+tag) | ||
| repository = strings.TrimPrefix(repository, "docker.io/library/") | ||
| repository = strings.TrimPrefix(repository, "docker.io/") |
There was a problem hiding this comment.
There was a problem hiding this comment.
same for this, this will be done in new PR!
|
As usual, please squash commits |
fahedouch
force-pushed
the
inspect-image
branch
3 times, most recently
from
dc52fd7
to
be8d9a0
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
|
Added commit bcd29a7 |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
inspect-image
branch
from
ba1dfc0
to
bcd29a7
Compare
same as
docker image inspectanddocker inspectrelated ticket #222