Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap timeouts #70

Merged
merged 1 commit into from
Oct 3, 2022
Merged

ldap timeouts #70

merged 1 commit into from
Oct 3, 2022

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Oct 2, 2022

Add the properties for connection and operations timeout.
Prerequisites for adding the timeouts' config in https://github.com/collective/pas.plugins.ldap

(see also collective/pas.plugins.ldap#61)

jensens
jensens approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jensens jensens requested a review from rnixx October 2, 2022 23:07
rnixx
rnixx reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@rnixx rnixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rnixx rnixx merged commit 676c774 into conestack:master Oct 3, 2022
@mamico mamico deleted the ldap_timeout branch October 3, 2022 12:23
@mamico mamico mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnixx rnixx rnixx left review comments

@jensens jensens jensens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamico @jensens @rnixx