Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to handle VC version matrix. #36

Closed
wants to merge 1 commit into from
Closed

Added the ability to handle VC version matrix. #36

wants to merge 1 commit into from

Conversation

pelson
Copy link
Contributor

@pelson pelson commented May 17, 2016

No description provided.

@pelson
Copy link
Contributor Author

pelson commented May 17, 2016

There are a few other details that would be needed here, such as how to activate the vc package for testing. I have been trying this out with conda-smithy, and it is working a treat though. (and has lead to a discussion at conda-forge/glpk-feedstock#10)

jakirkham
jakirkham reviewed Jun 16, 2016
View reviewed changes
conda_build_all/tests/unit/test_version_matrix.py
expected = {(('vc', '9'), ('python', '2.7')),
(('vc', '10'), ('python', '2.7')),
(('vc', '10'), ('python', '3.4'))}
self.assertEqual(r, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be handling 14 in these cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers have no significance in these unit tests. For instance, if there is a vc 99 that should also be included.

This was referenced Oct 10, 2016
Merged
Closed
@jakirkham jakirkham mentioned this pull request Oct 11, 2016
Closed
@jakirkham
Copy link
Member

Would you please take a look at this PR, @msarahan? This is the sort of thing that we need for tk and will need for curl ( conda-forge/curl-feedstock#11 ).

@jakirkham jakirkham mentioned this pull request Oct 11, 2016
Closed
@isuruf
Copy link

isuruf commented Jan 17, 2017

ping

@msarahan
Copy link
Contributor

Sorry, I don't have bandwidth to dig in here. I think that the build customization PR (conda/conda-build#1585) will obviate this, but this is probably still important until that has solidified. If it works (and I trust that it does) then I am in support of this PR.

@pelson
Copy link
Contributor Author

pelson commented Sep 21, 2017

Closing this out - #65 (comment) was a helpful conversation. conda-build 3 helps with VC variants, and it the right way to go long-term.

@pelson pelson closed this Sep 21, 2017
@pelson pelson mentioned this pull request Jan 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pelson @jakirkham @isuruf @msarahan