-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to handle VC version matrix. #36
Conversation
There are a few other details that would be needed here, such as how to activate the |
expected = {(('vc', '9'), ('python', '2.7')), | ||
(('vc', '10'), ('python', '2.7')), | ||
(('vc', '10'), ('python', '3.4'))} | ||
self.assertEqual(r, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be handling 14 in these cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The numbers have no significance in these unit tests. For instance, if there is a vc 99
that should also be included.
Would you please take a look at this PR, @msarahan? This is the sort of thing that we need for |
ping |
Sorry, I don't have bandwidth to dig in here. I think that the build customization PR (conda/conda-build#1585) will obviate this, but this is probably still important until that has solidified. If it works (and I trust that it does) then I am in support of this PR. |
Closing this out - #65 (comment) was a helpful conversation. conda-build 3 helps with VC variants, and it the right way to go long-term. |
No description provided.