Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Windows hack for Re-rendering [ci skip] #11

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Weird Windows hack for Re-rendering [ci skip] #11

merged 1 commit into from
Oct 14, 2016

Conversation

jakirkham
Copy link
Member

Adds a weird Windows hack for re-rendering. Here we provide a few lines in conda-forge.yml that are left commented, but can be uncommented for Windows re-rendering only.

Basically my suggestion until we have something better is to do the following.

  1. Re-render with this commented.
  2. Commit all changes.
  3. Uncomment matrix section.
  4. Re-render again
  5. Recomment this section.
  6. Only commit appveyor.yml (possibly amending the last re-rendering commit).

This should get us a little closer to a stable process for doing this.

@jakirkham
Copy link
Member Author

@pelson, is there a way ATM to make a matrix OS specific for conda-smithy? I think that would greatly reduce stress of re-renderings on feedstocks like this one using vc. If there isn't don't worry about it, proper handling of vc at the conda-build-all level ( and possibly conda-build @msarahan 😉 ) is far more useful than adding in OS matrix support to conda-forge.yml

@jakirkham jakirkham changed the title Weird Windows hack for Re-rendering Weird Windows hack for Re-rendering [ci skip] Oct 10, 2016
@pelson
Copy link
Member

pelson commented Oct 10, 2016

@jakirkham - if you want conda-tools/conda-build-all#36 I can resurrect that one. I'd be more than happy to have that one finally ticked off so that we can just express vc as the dependency, and not 'python'...

@jakirkham
Copy link
Member Author

That sounds like a great idea, @pelson. 😄 It is just unclear to me whether we would need to elevate the status of vc in conda-build or not. ( conda/conda-build#1445 )

@jjhelmus
Copy link
Contributor

Seems like a reasonable solution until the tooling around vc is complete.

@jjhelmus jjhelmus merged commit 4aa9b5f into conda-forge:master Oct 14, 2016
@jakirkham jakirkham deleted the kludgy_win_config branch October 14, 2016 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants