Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with CUDA 12 #117

Merged
merged 47 commits into from
May 31, 2023
Merged

Build with CUDA 12 #117

merged 47 commits into from
May 31, 2023

Conversation

pentschev
Copy link
Contributor

@pentschev pentschev commented Apr 12, 2023 •
edited by jakirkham
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Update UCX to build CUDA 12 from new packaging format and CUDA 10/11 with the legacy cudatoolkit package.

Fixes #116
Closes #126

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ucx-split-feedstock/actions/runs/4682466717.

@jakirkham jakirkham marked this pull request as draft April 13, 2023 00:27
@jakirkham
Copy link
Member

jakirkham commented Apr 13, 2023 •
edited
Loading

Thanks Peter! 🙏

Marking this as a draft PR for clarity. Hope that is ok 🙂

Edit: Also added a "Fixes" note in the OP tying this to the related issue

jakirkham
jakirkham reviewed Apr 20, 2023
View reviewed changes
recipe/install_ucx.sh Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented May 22, 2023

We will be able to drop the patch for CUDA 12 after updating to 1.14.1 in #124, since it has been released upstream. 🎉

@jakirkham
Copy link
Member

Would it be possible to resolve conflicts here now that PR ( #124 ) is merged?

@pentschev
Copy link
Contributor Author

Would it be possible to resolve conflicts here now that PR ( #124 ) is merged?

Done! 🙂

@jakirkham jakirkham mentioned this pull request May 27, 2023
Closed
jakirkham
jakirkham reviewed May 30, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter! 🙏

Had a couple suggestions on how we might simplify things a bit more

recipe/install_ucx.sh Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@pentschev @jakirkham
Use cuda-version and remove redundant target_platform
212af63 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ucx-split-feedstock/actions/runs/5119688092.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited by jakirkham
Loading

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ucx-split-feedstock/actions/runs/5136615669.

Edit: There were some package issues that are now resolved ( conda-forge/conda-forge-pinning-feedstock#4525 (comment) ). Rerunning

@jakirkham jakirkham added the automerge Merge the PR when CI passes label May 31, 2023
@jakirkham
Copy link
Member

Thanks Peter! 🙏

Lets get this once CI passes

@github-actions github-actions bot merged commit 78e8d08 into conda-forge:main May 31, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@pentschev pentschev deleted the cuda-12-nvidia-channel branch October 11, 2023 18:23
@dmargala dmargala mentioned this pull request Apr 25, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@Akshay-Venkatesh Akshay-Venkatesh Awaiting requested review from Akshay-Venkatesh Akshay-Venkatesh is a code owner

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner

@leofang leofang Awaiting requested review from leofang leofang is a code owner

@matthiasdiener matthiasdiener Awaiting requested review from matthiasdiener matthiasdiener is a code owner

@quasiben quasiben Awaiting requested review from quasiben quasiben is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UCX: Support CUDA 12
4 participants
@pentschev @jakirkham @leofang @bdice