Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tensorboardX recipe #4778

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Add tensorboardX recipe #4778

merged 2 commits into from
Jan 11, 2018

Conversation

mdraw
Copy link
Member

@mdraw mdraw commented Jan 10, 2018

Packages https://github.com/lanpa/tensorboard-pytorch, a library for direct tensorboard logging of NumPy arrays, PyTorch tensors etc. without TensorFlow or TensorBoard requirements.

Notes:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorboardx) and found it was in an excellent condition.


test:
imports:
- tensorboardX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests. (more imports are fine)

@mdraw
Copy link
Member Author

mdraw commented Jan 11, 2018

All submodules are now imported at test time. Is it okay now?

@CJ-Wright
Copy link
Member

This is noarch, and thus only needs to pass on circle.

@CJ-Wright CJ-Wright merged commit 854f5b7 into conda-forge:master Jan 11, 2018
@mdraw
Copy link
Member Author

mdraw commented Jan 14, 2018

Thanks for reviewing and merging, @CJ-Wright.

@mdraw mdraw deleted the tensorboardx branch January 14, 2018 20:28
@lanpa
Copy link

lanpa commented Jan 27, 2018

@mdraw I always test with tensorboardX with tensorflow-tensorboard. Can you provide more information about the compatibility? thanks

@mdraw
Copy link
Member Author

mdraw commented Jan 28, 2018

I tried it again on a new Anaconda installation with tensorflow-tensorboard and it works now 👍. There was probably an issue with my previous install that I can't reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants